TheBounty Renderer (rewrite for wxWidgets)

[povmaniac]

Last attempt (3th) for merge to master. I hope this time all are corrected.

[Akira1364]

Just so you know, the latest version you posted doesn't work at all in Wings 2.1. It fails everytime when it tries to export the scene to XML (whether or not you actually have it set to "save" the XML file.)

[povmaniac]

(10-27-2016 04:29 PM)Akira1364 Wrote:  Just so you know, the latest version you posted doesn't work at all in Wings 2.1. It fails everytime when it tries to export the scene to XML (whether or not you actually have it set to "save" the XML file.)

Can you say exactly what version you mean? And what OS are you use? Windows 10 x64? Windows 7?
Its working fine here under win10 and win7 x64 with Wings3D 2.0.x and 2.1.x
Btw, I are update the download link on TheBounty page. https://www.thebountyrenderer.org/system...1477624774

Greetings...

[micheus]

I'm getting a build error related to a variable not being used: OpenGL in ui_material.erl:20

Quote:erlc -Werror -pa ../../ebin -pa ../../intl_tools -I ../../intl_tools -I ../../src -I ../../e3d +debug_info -o../../plugins/import_export wpc_thebounty.erl
compile: warnings being treated as errors
f:/unixlike/src/wings/plugins_src/import_export/thebounty/ui_material.erl:20: variable 'OpenGL' is unused
Makefile:81: recipe for target '../../plugins/import_export/wpc_thebounty.beam' failed
make[4]: *** [../../plugins/import_export/wpc_thebounty.beam] Error 1

by commenting that line I could build the plugin and then I got a runt-time error related to the advise I did in post #163:

Quote:> f:/PROGRA~1/THEBOU~1/THEBOU~2.EXE -pp F:\Program Files\thebounty/plugins -f png wpc_thebounty-3860-6FERFO.xml c:/TEMP/wx-POV-Ray
INFO: TheBounty 0.1.6
INFO: The plugin path is: F:\Program
INFO: Environment: Loading plugins ...
ERROR: Environment: There is no image handlers registered
ERROR: Couldn't find any valid image format, image handlers missing?

in wpc_thebounty.erl:446
PluginsPath = "-pp "++format(Renderer)++"/plugins",
must be replaced by
PluginsPath = "-pp "++wings_job:quote(format(Renderer)++"/plugins"),

That is strange you didn't get that build error, since warnings are set to raise a error during the build process.

I think that it's convenient you add (to readme.txt) an observation about the need for run make clean every time we need to rebuild the plugin since any change made to a file into TheBounty subfolder will not be processed. That only happens if we change something in wpc_thebounty.erl. (that is very annoying)

Also, I believe you must include you into the AUTHORS.txt file.

[povmaniac]

Thanks for advice. I are not related the issue with haven spaces in the 'plugins path' with the use of 'wings_job:quote'. Now is fixed.
The Opengl issue, is because during all time of rewrite exporter, I changed 'Werror' for 'W0' for silent a lot of 'unused variable' warnings.
I also use 'clean' every time for all of my projects, by default. That 'vice' avoid some errors, and create more safe binaries.

About AUTHORS.txt.. I have my name in every file of code..

Code:

%%
%%  This file is part of TheBounty exporter for Wings3D 2.0.1 or above.
%%  Copyright (C) 2013-2016 Pedro Alcaide, aka povmaniac.
%%  Contact: thebountyrenderer@gmail.com
%%  See AUTHORS.txt for a complete list of authors.

[micheus]

(10-28-2016 02:52 PM)povmaniac Wrote:  I changed 'Werror' for 'W0' for silent a lot of 'unused variable' warnings.

It can be annoying but it makes the process safe. If we just have merged your code we would need to fix it before generate a new version.

Quote:About AUTHORS.txt.. I have my name in every file of code...

that is not what I see in your pull request: https://github.com/dgud/wings/pull/221/f...b6bcffdeR1

It seems like your local branch isn't the same pushed.

[micheus]

Thanks for the fixes.

[micheus]

povmaniac is no longer working on this plugin as well as he removed the versions he had made available before.

In case someone still wants to use his TheBounty render I'm making available the version we were using before which was a branch of the old Yafaray plugin - it's a non official plugin!

It can be found here.